storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "P. Taylor Goetz" <ptgo...@gmail.com>
Subject Re: possible typo in storm-core/pom.xml
Date Mon, 10 Feb 2014 19:09:53 GMT
Yep. That's a harmless typo.

It shouldn't be there, but its presence has no effect.

- Taylor

> On Feb 10, 2014, at 1:16 PM, Derek Dagit <derekd@yahoo-inc.com> wrote:
> 
> I noticed what appears to be a typo in the storm-core/pom.xml, but unit tests still pass
and word_count still runs.
> 
> https://github.com/apache/incubator-storm/blob/ffc7a81bfba60c735dd6801af4f5e8db3812658c/storm-core/pom.xml#L240
> 
> This is probably a typo in the groupId, but I have not noticed that it breaks anything
so far.
> 
> I'm new to the maven shade plugin, so I could be missing something.  The POM uses a whitelist-style
<includes> in the <artifactSet>.  But I looked at a my build of rc3, and we are
still shading storm clj source and classes correctly.  (I see thrift7 in the class files and
in the source after unpacking the jar.)
> 
> 
> Could someone confirm?
> -- 
> Derek
> 
>> On 2/9/14, 23:10, P. Taylor Goetz wrote:
>> Please vote on releasing the following candidate as Apache Storm (incubating) version
0.9.1.
>> 
>> The tag to be voted upon is v0.9.1-incubating:
>> 
>> https://git-wip-us.apache.org/repos/asf?p=incubator-storm.git;a=tree;h=ffc7a81bfba60c735dd6801af4f5e8db3812658c;hb=ffc7a81bfba60c735dd6801af4f5e8db3812658c
>> 
>> The release files, signatures and digests can be found here:
>> 
>> http://people.apache.org/~ptgoetz/storm/storm-0.9.1-incubating-dist-rc3
>> 
>> The release artifacts are signed with the key available here:
>> 
>> https://git-wip-us.apache.org/repos/asf?p=incubator-storm.git;a=blob_plain;f=KEYS;hb=22b832708295fa2c15c4f3c70ac0d2bc6fded4bd
>> 
>> The staging repository for this release can be found here:
>> 
>> https://repository.apache.org/content/repositories/orgapachestorm-1002/
>> 
>> The generated reports and documentation for this release can be found here:
>> 
>> http://people.apache.org/~ptgoetz/storm/storm-0.9.1-incubating-report-rc3
>> 
>> 
>> The vote will be open until Wednesday, February 12, at 05:00 UTC
>> and passes if a majority of at least 3 +1 and no -1 PPMC votes are cast.
>> 
>> [ ] +1 Release this package as Apache Storm 0.9.0-incubating
>> [ ] -1 Do not release this package because ...
>> 
>> 
>> - Taylor

Mime
View raw message