Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: stdcxx-dev@incubator.apache.org
Message-ID: <4526C2DE.2020004@roguewave.com>
Date: Fri, 06 Oct 2006 14:55:58 -0600
From: Martin Sebor <sebor@roguewave.com>
Organization: Rogue Wave Software
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060417
MIME-Version: 1.0
To: stdcxx-dev@incubator.apache.org
Subject: Re: [PATCH] STDCXX-93
References: <45266CF8.60900@kyiv.vdiweb.com>
In-Reply-To: <45266CF8.60900@kyiv.vdiweb.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Farid Zaripov wrote:
>  > -----Original Message-----
>  > From: Martin Sebor [mailto:sebor@roguewave.com]
>  > Sent: Thursday, October 05, 2006 6:59 PM
>  > To: stdcxx-dev@incubator.apache.org
>  > Subject: Re: [PATCH] STDCXX-93
>  >
>  > We should either pass in the size of the destination buffer
>  > or some large value that windows can deal with.
> 
>   First, I have made this, but then I had seen the first mbstowcs() call 
> with length of source string in the size and changed by analogy.
> 
>   New patch is attached.

This looks correct to me.

Just one request regarding formatting:

[...]
> @@ -804,9 +805,9 @@
>          // (at an appropriately aligned offset) and set its offset
>          const char *str =
>              _RWSTD_STATIC_CAST (const char*, pun->abmon (t.tm_mon, 0));
> -
>          wchar_t *pwbuf = _RWSTD_REINTERPRET_CAST (wchar_t*, pbuf + off);
> -        _RWSTD_SIZE_T size = mbstowcs (pwbuf, str, _RWSTD_SIZE_MAX);
> +        _RWSTD_SIZE_T size = mbstowcs (pwbuf, str,
> +            (bufsize - off) / sizeof (*pwbuf));

The style of indentation we've been following breaks the statement
above either after the equals sign

     _RWSTD_SIZE_T size =
         mbstowcs (pwbuf, str, (bufsize - off) / sizeof *pwbuf);

or (IMHO, less preferably) indents the function arguments on the
next lines to begin in the same column as the first argument on
the first line.

     _RWSTD_SIZE_T size = mbstowcs (pwbuf, str,
                                    (bufsize - off) / sizeof *pwbuf);

The goal is to use indentation to group subexpression according
to their role in the complete expression or statement to help
readability.

Martin