Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 31409 invoked from network); 3 Oct 2006 15:32:00 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 3 Oct 2006 15:32:00 -0000 Received: (qmail 30222 invoked by uid 500); 3 Oct 2006 15:32:00 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 30209 invoked by uid 500); 3 Oct 2006 15:32:00 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 30198 invoked by uid 99); 3 Oct 2006 15:32:00 -0000 Received: from idunn.apache.osuosl.org (HELO idunn.apache.osuosl.org) (140.211.166.84) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Oct 2006 08:32:00 -0700 X-ASF-Spam-Status: No, hits=0.0 required=5.0 tests= Received: from [208.30.140.160] ([208.30.140.160:58565] helo=moroha.quovadx.com) by idunn.apache.osuosl.org (ecelerity 2.1.1.8 r(12930)) with ESMTP id 62/B2-08153-C6282254 for ; Tue, 03 Oct 2006 08:31:57 -0700 Received: from qxvcexch01.ad.quovadx.com (qxvcexch01.ad.quovadx.com [192.168.170.59]) by moroha.quovadx.com (8.13.6/8.13.6) with ESMTP id k93FUu0f022769 for ; Tue, 3 Oct 2006 15:30:58 GMT Received: from [10.70.3.113] ([10.70.3.113]) by qxvcexch01.ad.quovadx.com with Microsoft SMTPSVC(6.0.3790.1830); Tue, 3 Oct 2006 09:31:59 -0600 Message-ID: <45228275.5080100@roguewave.com> Date: Tue, 03 Oct 2006 09:32:05 -0600 From: Martin Sebor Organization: Rogue Wave Software User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060417 X-Accept-Language: en-us, en MIME-Version: 1.0 To: stdcxx-dev@incubator.apache.org Subject: Re: [PATCH] Scripts, generating solution and projects for MSVC/ICC [2] References: In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 03 Oct 2006 15:31:59.0119 (UTC) FILETIME=[10E6E9F0:01C6E701] X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Farid Zaripov wrote: >>-----Original Message----- >>From: Martin Sebor [mailto:sebor@roguewave.com] >>Sent: Monday, October 02, 2006 6:00 PM >>To: stdcxx-dev@incubator.apache.org >>Subject: Re: [PATCH] Scripts, generating solution and >>projects for MSVC/ICC [2] >> >> >>> Should we replace #ifdef _RWBUILD_std to #ifdef _RWSTD_LIB_SRC in >>>_defs.h? >> >>Yes. It should also key in on _RWSHARED. > > _RWSHARED is present in outer #ifdef: > --------------------- > #if (defined (_WIN32) || defined (_WIN64)) && \ > (defined (RWDLL) || defined (_RWSHARED)) > > Commited here: http://svn.apache.org/viewvc?view=rev&revision=452509 Okay. FYI, the _WIN32 || _WIN64 conditional above (and in the rest of our code) can be simplified to just _WIN32 since the macro is guaranteed to be #defined when _WIN64 is #defined. > > >>> CXX, LD, AR variables are used at configure step only. >> >>And not when bulding the lib? Why not? > > Because we use MS VisualStudio development envorinment (devenv.exe) > in build process. Devenv itself selects what tool should be invoked to > compile > the partucular source file (i.e. cl.exe for .c, .cpp files; rc for .rc > files). We > cannot change this behavior. Gotcha! It would be good to mention this in comments for each of these variables. Martin