Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: stdcxx-dev@incubator.apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
Message-ID: <43D542BD.7040305@roguewave.com>
Date: Mon, 23 Jan 2006 13:55:25 -0700
From: Liviu Nicoara <nicoara@roguewave.com>
User-Agent: Mozilla Thunderbird 1.0.7 (X11/20050923)
MIME-Version: 1.0
To: stdcxx-dev@incubator.apache.org
Subject: Re: 23.containers.deque.modifiers.cpp
References: <43CE6FAC.3000507@moscow.vdiweb.com>
 <43CFE7F6.4060208@roguewave.com> <43D01A83.4020206@roguewave.com>
 <43D5298C.2060009@roguewave.com>
In-Reply-To: <43D5298C.2060009@roguewave.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Martin Sebor wrote:
> Liviu Nicoara wrote:
> 
>>I have attached my tentative porting of lib.deque.modifiers test to the
>>new driver. Martin, I would appreciate suggestions for improving the
>>sections which use ToString class (one of those uses split formatting).
> 
> 
> I don't see the class defined in the test. Did you by any chance
> move/copy it into your version alg_test.h?

Yes, I did. My bad, I just wanted to get your feed-back on the
formatting bits and I didn't think that was important. I will stick a
ToString in each of the tests using it.

> 
> I think the bits that use the ToString class are fine. As soon as
> I'm done with the extension to rw_asnprintf() to format arrays of
> class X (we need to rename it!) it should be straightforward to
> simply remove the class and pass the arrays directly to rw_assert().

Super.

> 
> Btw., the old tests were designed to avoid invoking the RW_ASSERT
> macro except on failure (i.e., there's usually an if (failed) { }
> block around it). 

I got that. I will eliminate the conditionals from now on.

Thanks,
Liviu