Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 22945 invoked from network); 20 Jan 2006 02:52:07 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 20 Jan 2006 02:52:07 -0000 Received: (qmail 58645 invoked by uid 500); 20 Jan 2006 02:52:07 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 58632 invoked by uid 500); 20 Jan 2006 02:52:07 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 58619 invoked by uid 99); 20 Jan 2006 02:52:07 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Jan 2006 18:52:07 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [12.17.213.84] (HELO bco-exchange.bco.roguewave.com) (12.17.213.84) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Jan 2006 18:52:06 -0800 Received: from [10.70.3.113] (10.70.3.113 [10.70.3.113]) by bco-exchange.bco.roguewave.com with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2657.72) id ZGW28GJ1; Thu, 19 Jan 2006 19:44:55 -0700 Message-ID: <43D0512A.8030208@roguewave.com> Date: Thu, 19 Jan 2006 19:55:38 -0700 From: Martin Sebor User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050920 X-Accept-Language: en-us, en MIME-Version: 1.0 To: stdcxx-dev@incubator.apache.org Subject: Re: 21.string.cons test References: <43CE6FAC.3000507@moscow.vdiweb.com> <43CFE7F6.4060208@roguewave.com> In-Reply-To: <43CFE7F6.4060208@roguewave.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Liviu Nicoara wrote: > Attached is my attempt at converting the lib.string.cons test. It > contains the additional new_test.h/new.cpp and > string_test.h/string_test.cpp for support. Great, thanks! I spotted a few problems (the %lu formatting specifier used where size_t was being passed -- the correct C99 modifier for size_t is %zu). I corrected them and made a few other "improvements" (and also disabled the copy_string() function until we actually build a shared rwtest library) and committed the result here: http://svn.apache.org/viewcvs.cgi?rev=370707&view=rev Martin