sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daniel voros <daniel.vo...@gmail.com>
Subject Review Request 65734: Incremental import's upper bound ignores session time zone in Oracle
Date Wed, 21 Feb 2018 14:23:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65734/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-3288
    https://issues.apache.org/jira/browse/SQOOP-3288


Repository: sqoop-trunk


Description
-------

At the moment we're using SELECT SYSDATE FROM dual when getting current time from Oracle.

SYSDATE returns the underlying operating system's current time, while CURRENT_TIMESTAMP uses
the session time zone. This could lead to problems during incremental imports when Oracle's
time zone is different from the OS.

See descrition of SQOOP-3288 for details.


Diffs
-----

  src/java/org/apache/sqoop/manager/OracleManager.java 12613e3 


Diff: https://reviews.apache.org/r/65734/diff/1/


Testing
-------

- run oracle incremental tests
- tested on a cluster with saved and non-saved job as well


Thanks,

daniel voros


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message