Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7C2AA200BFF for ; Tue, 17 Jan 2017 16:31:58 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 7AB10160B46; Tue, 17 Jan 2017 15:31:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C56C7160B43 for ; Tue, 17 Jan 2017 16:31:57 +0100 (CET) Received: (qmail 39792 invoked by uid 500); 17 Jan 2017 15:31:57 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 39779 invoked by uid 500); 17 Jan 2017 15:31:56 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 39772 invoked by uid 99); 17 Jan 2017 15:31:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jan 2017 15:31:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 03D11314F14; Tue, 17 Jan 2017 15:31:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9104790322654242128==" MIME-Version: 1.0 Subject: Re: Review Request 55558: Fix ordering in column list query of PostgreSQL connector From: Attila Szabo To: Attila Szabo Cc: Szabolcs Vasas , Sqoop Date: Tue, 17 Jan 2017 15:31:55 -0000 Message-ID: <20170117153155.28414.44264@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Attila Szabo X-ReviewGroup: Sqoop X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/55558/ X-Sender: Attila Szabo X-ReviewBoard-ShipIt: 1 References: <20170116090756.28414.71249@reviews.apache.org> In-Reply-To: <20170116090756.28414.71249@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Attila Szabo X-ReviewRequest-Repository: sqoop-trunk archived-at: Tue, 17 Jan 2017 15:31:58 -0000 --===============9104790322654242128== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55558/#review161873 ----------------------------------------------------------- Ship it! Ship It! - Attila Szabo On Jan. 16, 2017, 9:07 a.m., Szabolcs Vasas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55558/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2017, 9:07 a.m.) > > > Review request for Sqoop and Attila Szabo. > > > Bugs: SQOOP-3124 > https://issues.apache.org/jira/browse/SQOOP-3124 > > > Repository: sqoop-trunk > > > Description > ------- > > Fix ordering in column list query of PostgreSQL connector > > > Diffs > ----- > > src/java/org/apache/sqoop/manager/PostgresqlManager.java bd882b9 > > Diff: https://reviews.apache.org/r/55558/diff/ > > > Testing > ------- > > I have run unit tests and PostgreSQL-related third party tests: > ant clean test > ant test -Dthirdparty=true -Dsqoop.thirdparty.lib.dir=libdir -Dmaxmemory=2048m -DtargetJavaVersion=1.7 -DjavaVersion=1.7 -Dsqoop.test.postgresql.connectstring.host_url=postgresqlserverer -Dtest.timeout=1000000 -Dtestcase=Postgresql* > > The column ordering is correct most of the time without this patch too the bug is hard to reproduce so it would be very hard to write an automated test to prove that this patch actually fixed a corner case. > However the currently available test cases can be run successfully which proves that the patch does not cause a regression. > > > Thanks, > > Szabolcs Vasas > > --===============9104790322654242128==--