Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 27E90200BFB for ; Wed, 11 Jan 2017 11:42:47 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 26909160B4E; Wed, 11 Jan 2017 10:42:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 71570160B2E for ; Wed, 11 Jan 2017 11:42:46 +0100 (CET) Received: (qmail 97893 invoked by uid 500); 11 Jan 2017 10:42:45 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 97876 invoked by uid 500); 11 Jan 2017 10:42:45 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 97868 invoked by uid 99); 11 Jan 2017 10:42:45 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Jan 2017 10:42:45 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3C298312A16; Wed, 11 Jan 2017 10:42:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6884262397674600871==" MIME-Version: 1.0 Subject: Re: Review Request 55001: Clean up expected exception logic in tests - part I. From: Attila Szabo To: Anna Szonyi , Attila Szabo Cc: Boglarka Egyed , Sqoop Date: Wed, 11 Jan 2017 10:42:45 -0000 Message-ID: <20170111104245.1676.22805@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Attila Szabo X-ReviewGroup: Sqoop X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/55001/ X-Sender: Attila Szabo X-ReviewBoard-ShipIt: 1 References: <20161228155731.1483.44102@reviews.apache.org> In-Reply-To: <20161228155731.1483.44102@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Attila Szabo X-ReviewRequest-Repository: sqoop-trunk archived-at: Wed, 11 Jan 2017 10:42:47 -0000 --===============6884262397674600871== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55001/#review161204 ----------------------------------------------------------- Ship it! Ship It! - Attila Szabo On Dec. 28, 2016, 3:57 p.m., Boglarka Egyed wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55001/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2016, 3:57 p.m.) > > > Review request for Sqoop, Attila Szabo and Anna Szonyi. > > > Bugs: SQOOP-3091 > https://issues.apache.org/jira/browse/SQOOP-3091 > > > Repository: sqoop-trunk > > > Description > ------- > > Normalizing test cases where we except an exception using JUnit's ExpectedException rule to make the code mor clean and self-explanatory. > > > Diffs > ----- > > src/test/com/cloudera/sqoop/TestAvroExport.java b51313895e8e5b5aa45aa7169b7200d50f53a792 > src/test/com/cloudera/sqoop/TestConnFactory.java 59c3455401c70acbac8a4d140639e611c03d30a5 > src/test/com/cloudera/sqoop/TestExportUpdate.java 95d7b6ae80c64ac4b6a574ada1d02e138d7c963a > src/test/com/cloudera/sqoop/TestParquetExport.java c6ddef6a82e99c8b6c03e0d71584bed50b60355b > src/test/com/cloudera/sqoop/TestSqoopOptions.java d95f904347191f84caa106a30a513978114eb5f0 > src/test/com/cloudera/sqoop/TestTargetDir.java 7aad7e15dcde092e0c674d5d818be9750d7347a6 > src/test/org/apache/sqoop/TestExportUsingProcedure.java cf5e2cd07ba3f322e53ebe9c3852eae13f78d133 > > Diff: https://reviews.apache.org/r/55001/diff/ > > > Testing > ------- > > ant test, ant clean test > > > Thanks, > > Boglarka Egyed > > --===============6884262397674600871==--