sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Boglarka Egyed (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-3090) Normalize test cases where expect an exception
Date Tue, 03 Jan 2017 13:43:58 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15795092#comment-15795092
] 

Boglarka Egyed commented on SQOOP-3090:
---------------------------------------

I have found some more affected test classes:
* TestClassWriter 
* LobFileStressTest
* TestIncrementalImport
* TestRecordParser
* TestSavedJobs

I'm opening a third subtask for them since the review of the other two tickets is in a far
gone state.

> Normalize test cases where expect an exception
> ----------------------------------------------
>
>                 Key: SQOOP-3090
>                 URL: https://issues.apache.org/jira/browse/SQOOP-3090
>             Project: Sqoop
>          Issue Type: Improvement
>    Affects Versions: 1.4.6
>            Reporter: Boglarka Egyed
>            Assignee: Boglarka Egyed
>            Priority: Minor
>
> Many test cases uses the following logic to test if an exception has been thrown:
> {code:java}
> try {
>       <do something>
>       fail("Expected exception");
>     } catch (someException e) {
>       // expected
>     }
>   }
> {code}
> This form is not self-explanatory enough and could be replaced by a one line ExpectedException
check which would be more clean.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message