sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Szabolcs Vasas <vasas.szabo...@gmail.com>
Subject Re: Review Request 55466: Clean up expected exception logic in tests - part III.
Date Fri, 27 Jan 2017 12:56:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55466/#review163253
-----------------------------------------------------------



Hi Bogi!

Thanks for the improvement but I tried to apply the patch but I did not succeed. Can you please
check it again? Also, I have a couple of comments below, please take a look.


src/perftest/LobFileStressTest.java (line 149)
<https://reviews.apache.org/r/55466/#comment234700>

    Since the exception is not caught anymore the code after line 149 will not run.



src/perftest/LobFileStressTest.java (line 217)
<https://reviews.apache.org/r/55466/#comment234701>

    Since the exception is not caught anymore the code after line 217 will not run.



src/test/com/cloudera/sqoop/metastore/TestSavedJobs.java (line 163)
<https://reviews.apache.org/r/55466/#comment234702>

    This code will not run because the exception is not caught anymore.


- Szabolcs Vasas


On Jan. 12, 2017, 6:32 p.m., Boglarka Egyed wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55466/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2017, 6:32 p.m.)
> 
> 
> Review request for Sqoop, Attila Szabo, Anna Szonyi, and Liz Szilagyi.
> 
> 
> Bugs: SQOOP-3100
>     https://issues.apache.org/jira/browse/SQOOP-3100
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Normalizing test cases where we except an exception using JUnit's ExpectedException rule
to make the code more clean and self-explanatory.
> 
> 
> Diffs
> -----
> 
>   src/perftest/LobFileStressTest.java dafebb423078edc55414fa676c9e0c31b6a725cf 
>   src/test/com/cloudera/sqoop/TestIncrementalImport.java 57f4433d8f50b37f102a8a8ada7196d9287b5557

>   src/test/com/cloudera/sqoop/lib/TestRecordParser.java 57bdb5fe057f74dcaef9e2e3d6e1d26d3af7833a

>   src/test/com/cloudera/sqoop/metastore/TestSavedJobs.java 1fb732439dd2c8f187af726935a335c993895bc5

>   src/test/com/cloudera/sqoop/orm/TestClassWriter.java ea31e9d5a1307e4179d6d21545c10b85c28566e1

> 
> Diff: https://reviews.apache.org/r/55466/diff/
> 
> 
> Testing
> -------
> 
> ant test, ant clean test
> 
> 
> Thanks,
> 
> Boglarka Egyed
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message