sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Boglarka Egyed <egyedb...@gmail.com>
Subject Re: Review Request 55558: Fix ordering in column list query of PostgreSQL connector
Date Mon, 16 Jan 2017 16:55:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55558/#review161755
-----------------------------------------------------------


Ship it!




Hi Szabi,

I have executed the unit and the 3rd party tests, everything seems to be OK. Thanks for the
fix!

Cheers,
Bogi

- Boglarka Egyed


On Jan. 16, 2017, 9:07 a.m., Szabolcs Vasas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55558/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2017, 9:07 a.m.)
> 
> 
> Review request for Sqoop and Attila Szabo.
> 
> 
> Bugs: SQOOP-3124
>     https://issues.apache.org/jira/browse/SQOOP-3124
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Fix ordering in column list query of PostgreSQL connector
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/manager/PostgresqlManager.java bd882b9 
> 
> Diff: https://reviews.apache.org/r/55558/diff/
> 
> 
> Testing
> -------
> 
> I have run unit tests and PostgreSQL-related third party tests:
> ant clean test
> ant test -Dthirdparty=true -Dsqoop.thirdparty.lib.dir=libdir -Dmaxmemory=2048m -DtargetJavaVersion=1.7
-DjavaVersion=1.7 -Dsqoop.test.postgresql.connectstring.host_url=postgresqlserverer -Dtest.timeout=1000000
-Dtestcase=Postgresql*
> 
> The column ordering is correct most of the time without this patch too the bug is hard
to reproduce so it would be very hard to write an automated test to prove that this patch
actually fixed a corner case. 
> However the currently available test cases can be run successfully which proves that
the patch does not cause a regression.
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message