sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Erzsebet Szilagyi <erzsebet.liz.szila...@gmail.com>
Subject Re: Review Request 55103: Clean up expected exception logic in tests - part II.
Date Mon, 02 Jan 2017 15:22:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55103/#review160329
-----------------------------------------------------------


Ship it!




Thank you for improving our testing!

- Erzsebet Szilagyi


On Dec. 30, 2016, 4:29 p.m., Boglarka Egyed wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55103/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2016, 4:29 p.m.)
> 
> 
> Review request for Sqoop, Attila Szabo and Anna Szonyi.
> 
> 
> Bugs: SQOOP-3092
>     https://issues.apache.org/jira/browse/SQOOP-3092
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Normalizing test cases where we except an exception using JUnit's ExpectedException rule
to make the code mor clean and self-explanatory.
> 
> 
> Diffs
> -----
> 
>   src/test/com/cloudera/sqoop/hive/TestHiveImport.java 26d087b0bede24afbcd029ce0aaa03b355b60040

>   src/test/com/cloudera/sqoop/hive/TestTableDefWriter.java 55e572ed11a5c9e765d3204881bb31d258a6f540

>   src/test/com/cloudera/sqoop/io/TestCodecMap.java 925c5446ab878786bc6403b06e458839cc603039

>   src/test/com/cloudera/sqoop/io/TestLobFile.java 129b03a5307f47fc3ba950fb93b528292682b229

>   src/test/org/apache/sqoop/hcat/TestHCatalogBasic.java 54b4552a792e5a4cf92a31a7e8d3354488de1a0e

>   src/test/org/apache/sqoop/mapreduce/db/TestTextSplitter.java 5cfb0a5a1998817311de033eb93686c9a3007237

>   src/test/org/apache/sqoop/mapreduce/db/TextSplitterHadoopConfIntegrationTest.java 043130ea8d806cf9e465e650a89a811a4be7bb7a

> 
> Diff: https://reviews.apache.org/r/55103/diff/
> 
> 
> Testing
> -------
> 
> ant test, ant clean test
> 
> 
> Thanks,
> 
> Boglarka Egyed
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message