sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Jarcec Cecho (JIRA)" <j...@apache.org>
Subject [jira] [Created] (SQOOP-2823) Sqoop2: RESTiliency: Remove repetitive try-catch block for accessing POST and PUT request
Date Fri, 05 Feb 2016 23:21:39 GMT
Jarek Jarcec Cecho created SQOOP-2823:
-----------------------------------------

             Summary: Sqoop2: RESTiliency: Remove repetitive try-catch block for accessing
POST and PUT request
                 Key: SQOOP-2823
                 URL: https://issues.apache.org/jira/browse/SQOOP-2823
             Project: Sqoop
          Issue Type: Bug
            Reporter: Jarek Jarcec Cecho
            Assignee: Jarek Jarcec Cecho
             Fix For: 1.99.7
         Attachments: SQOOP-2823.patch

I've noticed that we have quite a few repetition of code like this one:

{code}
     RoleBean bean = new RoleBean();

    try {
      JSONObject json = JSONUtils.parse(ctx.getRequest().getReader());
      bean.restore(json);
    } catch (IOException e) {
      throw new SqoopException(ServerError.SERVER_0003, "Can't read request content", e);
    }
{code}

It's relatively a lot of code just because {{ctx.getRequest()}} can throw an exception. I
would like to propose to create a method in our {{ctx}} wrapper to provide the {{getReader}}
method without any exception, which will simplify the code to:

{code}
    bean.restore(JSONUtils.parse(ctx.getReader()));
{code}

We'll of course throw an exception on failure - but using our {{SqoopException}} mechanism.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message