Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 418CD173CD for ; Tue, 2 Jun 2015 08:45:19 +0000 (UTC) Received: (qmail 47230 invoked by uid 500); 2 Jun 2015 08:45:18 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 47182 invoked by uid 500); 2 Jun 2015 08:45:18 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 46923 invoked by uid 99); 2 Jun 2015 08:45:18 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jun 2015 08:45:18 +0000 Date: Tue, 2 Jun 2015 08:45:18 +0000 (UTC) From: "Dian Fu (JIRA)" To: dev@sqoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (SQOOP-2385) Sqoop2: refactor code in HandlerUtils MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SQOOP-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu resolved SQOOP-2385. ---------------------------- Resolution: Duplicate Duplicate with SQOOP-2386. Due to network issue, has created this issue twice and just close this one. > Sqoop2: refactor code in HandlerUtils > ------------------------------------- > > Key: SQOOP-2385 > URL: https://issues.apache.org/jira/browse/SQOOP-2385 > Project: Sqoop > Issue Type: Bug > Reporter: Dian Fu > Assignee: Dian Fu > > In {{HandlerUtils}}, there is code like this: > {code} > if (repository.findJob(identifier) != null) { > jobId = repository.findJob(identifier).getPersistenceId(); > ... > } > {code} > This will execute {{repository.findJob}} twice, this is unnecessary. -- This message was sent by Atlassian JIRA (v6.3.4#6332)