Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0385F10B26 for ; Fri, 5 Jun 2015 12:07:39 +0000 (UTC) Received: (qmail 5263 invoked by uid 500); 5 Jun 2015 12:07:38 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 5223 invoked by uid 500); 5 Jun 2015 12:07:38 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 5210 invoked by uid 500); 5 Jun 2015 12:07:38 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 5206 invoked by uid 99); 5 Jun 2015 12:07:38 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jun 2015 12:07:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DD6F01DF393; Fri, 5 Jun 2015 12:07:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7251484730976902490==" MIME-Version: 1.0 Subject: Review Request 35122: Sqoop2: findJob will throw exception when job doesn't exist From: "Dian Fu" To: "Sqoop" , "Dian Fu" Date: Fri, 05 Jun 2015 12:07:37 -0000 Message-ID: <20150605120737.7997.59211@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Dian Fu" X-ReviewGroup: Sqoop X-ReviewRequest-URL: https://reviews.apache.org/r/35122/ X-Sender: "Dian Fu" Reply-To: "Dian Fu" X-ReviewRequest-Repository: sqoop-sqoop2 --===============7251484730976902490== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35122/ ----------------------------------------------------------- Review request for Sqoop. Bugs: sqoop-2390 https://issues.apache.org/jira/browse/sqoop-2390 Repository: sqoop-sqoop2 Description ------- findConnector return null when connector doesn't exist, while findJob and findLink throw exception when job and link doesn't exist. This is inconsistent. Diffs ----- common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java e5fbe2d repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 774c3b4 repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java 6f975a6 repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 1ee7996 repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java ad601b4 repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestLinkHandling.java 35736d4 Diff: https://reviews.apache.org/r/35122/diff/ Testing ------- Thanks, Dian Fu --===============7251484730976902490==--