Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 25B5210EEF for ; Wed, 3 Jun 2015 07:43:41 +0000 (UTC) Received: (qmail 72105 invoked by uid 500); 3 Jun 2015 07:43:41 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 72066 invoked by uid 500); 3 Jun 2015 07:43:41 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 72053 invoked by uid 500); 3 Jun 2015 07:43:40 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 72048 invoked by uid 99); 3 Jun 2015 07:43:40 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jun 2015 07:43:40 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6136F1CBF75; Wed, 3 Jun 2015 07:43:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1135924227437686371==" MIME-Version: 1.0 Subject: Re: Review Request 34930: SQOOP-2386: Sqoop2: refactor code in HandlerUtils From: "Abraham Elmahrek" To: "Abraham Elmahrek" , "Sqoop" , "Dian Fu" Date: Wed, 03 Jun 2015 07:43:40 -0000 Message-ID: <20150603074340.7997.38611@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Abraham Elmahrek" X-ReviewGroup: Sqoop X-ReviewRequest-URL: https://reviews.apache.org/r/34930/ X-Sender: "Abraham Elmahrek" References: <20150602083553.1498.61329@reviews.apache.org> In-Reply-To: <20150602083553.1498.61329@reviews.apache.org> Reply-To: "Abraham Elmahrek" X-ReviewRequest-Repository: sqoop-sqoop2 --===============1135924227437686371== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34930/#review86375 ----------------------------------------------------------- server/src/main/java/org/apache/sqoop/handler/HandlerUtils.java What's the difference between using `Repository` versus `ConnectorManager`? - Abraham Elmahrek On June 2, 2015, 8:35 a.m., Dian Fu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34930/ > ----------------------------------------------------------- > > (Updated June 2, 2015, 8:35 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > In HandlerUtils, there is code like this: > if (repository.findJob(identifier) != null) { > jobId = repository.findJob(identifier).getPersistenceId(); > ... > } > This will execute repository.findJob twice, this is unnecessary. > > > Diffs > ----- > > core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java d1537bf > server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5128a27 > server/src/main/java/org/apache/sqoop/handler/HandlerUtils.java 93ff60b > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java c96d66d > > Diff: https://reviews.apache.org/r/34930/diff/ > > > Testing > ------- > > > Thanks, > > Dian Fu > > --===============1135924227437686371==--