Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 92D8C10EA0 for ; Wed, 3 Jun 2015 07:37:47 +0000 (UTC) Received: (qmail 55813 invoked by uid 500); 3 Jun 2015 07:37:47 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 55754 invoked by uid 500); 3 Jun 2015 07:37:47 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 55721 invoked by uid 500); 3 Jun 2015 07:37:46 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 55697 invoked by uid 99); 3 Jun 2015 07:37:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jun 2015 07:37:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9BE111CBF75; Wed, 3 Jun 2015 07:37:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4122951936440100187==" MIME-Version: 1.0 Subject: Re: Review Request 34924: SQOOP2: Check whether resource exists before run privilege check From: "Abraham Elmahrek" To: "Abraham Elmahrek" , "Sqoop" , "Dian Fu" Date: Wed, 03 Jun 2015 07:37:46 -0000 Message-ID: <20150603073746.7997.70425@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Abraham Elmahrek" X-ReviewGroup: Sqoop X-ReviewRequest-URL: https://reviews.apache.org/r/34924/ X-Sender: "Abraham Elmahrek" References: <20150602050141.3245.315@reviews.apache.org> In-Reply-To: <20150602050141.3245.315@reviews.apache.org> Reply-To: "Abraham Elmahrek" X-ReviewRequest-Repository: sqoop-sqoop2 --===============4122951936440100187== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34924/#review86373 ----------------------------------------------------------- server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java The logic should be in parsing since a new resource is created using `MResource(string, string)` which will call `MResource.Type.valueOf(..)`. server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java `MResource.Type.valueOf` should throw an exception if the type doesn't exist accoring to http://docs.oracle.com/javase/7/docs/api/java/lang/Enum.html#valueOf(java.lang.Class,%20java.lang.String). There's no need for the switch statement i believe. - Abraham Elmahrek On June 2, 2015, 5:01 a.m., Dian Fu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34924/ > ----------------------------------------------------------- > > (Updated June 2, 2015, 5:01 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Check whether resource exists before run privilege check, including grant/check_privilege. If resource does not exists, throw "none resource exception" > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java e5fbe2d > server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java 00f4b52 > > Diff: https://reviews.apache.org/r/34924/diff/ > > > Testing > ------- > > > Thanks, > > Dian Fu > > --===============4122951936440100187==--