sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dian Fu" <dian0511...@gmail.com>
Subject Review Request 34930: SQOOP-2386: Sqoop2: refactor code in HandlerUtils
Date Tue, 02 Jun 2015 08:35:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34930/
-----------------------------------------------------------

Review request for Sqoop.


Repository: sqoop-sqoop2


Description
-------

In HandlerUtils, there is code like this:
 if (repository.findJob(identifier) != null) {
      jobId = repository.findJob(identifier).getPersistenceId();
      ...
 }
This will execute repository.findJob twice, this is unnecessary.


Diffs
-----

  core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java d1537bf 
  server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 5128a27 
  server/src/main/java/org/apache/sqoop/handler/HandlerUtils.java 93ff60b 
  server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java c96d66d 

Diff: https://reviews.apache.org/r/34930/diff/


Testing
-------


Thanks,

Dian Fu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message