Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6BB0A107B7 for ; Sun, 7 Dec 2014 16:38:25 +0000 (UTC) Received: (qmail 64388 invoked by uid 500); 7 Dec 2014 16:38:24 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 64349 invoked by uid 500); 7 Dec 2014 16:38:24 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 64331 invoked by uid 500); 7 Dec 2014 16:38:23 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 64325 invoked by uid 99); 7 Dec 2014 16:38:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 07 Dec 2014 16:38:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1E65F1D22C7; Sun, 7 Dec 2014 16:38:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7847004555850330259==" MIME-Version: 1.0 Subject: Re: Review Request 28678: SQOOP-1840 Sqoop2: Guard test DerbyProvider from infinite waits in Derby implementation From: "Jarek Cecho" To: "Sqoop" , "Jarek Cecho" Date: Sun, 07 Dec 2014 16:38:21 -0000 Message-ID: <20141207163821.5766.60182@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jarek Cecho" X-ReviewGroup: Sqoop X-ReviewRequest-URL: https://reviews.apache.org/r/28678/ X-Sender: "Jarek Cecho" References: <20141203214720.32525.17590@reviews.apache.org> In-Reply-To: <20141203214720.32525.17590@reviews.apache.org> Reply-To: "Jarek Cecho" X-ReviewRequest-Repository: sqoop-sqoop2 --===============7847004555850330259== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28678/ ----------------------------------------------------------- (Updated Dec. 7, 2014, 4:38 p.m.) Review request for Sqoop. Changes ------- Rebased. Bugs: SQOOP-1840 https://issues.apache.org/jira/browse/SQOOP-1840 Repository: sqoop-sqoop2 Description ------- I've added the explicit timeout and guarded call to server.stop(). Diffs (updated) ----- common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java 2597325 Diff: https://reviews.apache.org/r/28678/diff/ Testing ------- Seems to be working for me well for both positive and negative case. 1) Tried case when there is nothing wrong and the tests are passing 2) Tried case when that would otherwise lead to infinite loop and the test failed fast. Thanks, Jarek Cecho --===============7847004555850330259==--