sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 28678: SQOOP-1840 Sqoop2: Guard test DerbyProvider from infinite waits in Derby implementation
Date Sun, 07 Dec 2014 16:38:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28678/
-----------------------------------------------------------

(Updated Dec. 7, 2014, 4:38 p.m.)


Review request for Sqoop.


Changes
-------

Rebased.


Bugs: SQOOP-1840
    https://issues.apache.org/jira/browse/SQOOP-1840


Repository: sqoop-sqoop2


Description
-------

I've added the explicit timeout and guarded call to server.stop().


Diffs (updated)
-----

  common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java 2597325 

Diff: https://reviews.apache.org/r/28678/diff/


Testing
-------

Seems to be working for me well for both positive and negative case.

1) Tried case when there is nothing wrong and the tests are passing
2) Tried case when that would otherwise lead to infinite loop and the test failed fast.


Thanks,

Jarek Cecho


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message