Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4777C17D7C for ; Fri, 31 Oct 2014 23:17:57 +0000 (UTC) Received: (qmail 1970 invoked by uid 500); 31 Oct 2014 23:17:57 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 1925 invoked by uid 500); 31 Oct 2014 23:17:57 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 1911 invoked by uid 500); 31 Oct 2014 23:17:56 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 1907 invoked by uid 99); 31 Oct 2014 23:17:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 Oct 2014 23:17:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BD4D31DFA35; Fri, 31 Oct 2014 23:18:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2988137463341613710==" MIME-Version: 1.0 Subject: Re: Review Request 27431: Cleanup: Naming and ordering of methods in Repo relates classes From: "Abraham Elmahrek" To: "Abraham Elmahrek" , "Veena Basavaraj" , "Sqoop" Date: Fri, 31 Oct 2014 23:18:00 -0000 Message-ID: <20141031231800.7138.86541@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Abraham Elmahrek" X-ReviewGroup: Sqoop X-ReviewRequest-URL: https://reviews.apache.org/r/27431/ X-Sender: "Abraham Elmahrek" References: <20141031231726.7137.73208@reviews.apache.org> In-Reply-To: <20141031231726.7137.73208@reviews.apache.org> Reply-To: "Abraham Elmahrek" X-ReviewRequest-Repository: sqoop-sqoop2 --===============2988137463341613710== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 31, 2014, 11:17 p.m., Abraham Elmahrek wrote: > > Ship It! Which Jira is this associated with? - Abraham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27431/#review59436 ----------------------------------------------------------- On Oct. 31, 2014, 5:16 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27431/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2014, 5:16 p.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > core/src/main/java/org/apache/sqoop/driver/JobManager.java f6447c6 > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 2aeb07e > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java ad380d3 > core/src/main/java/org/apache/sqoop/repository/Repository.java 79742b9 > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java b996a0b > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java 4c2d062 > > Diff: https://reviews.apache.org/r/27431/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Veena Basavaraj > > --===============2988137463341613710==--