Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@sqoop.apache.org
Content-Type: multipart/alternative;
 boundary="===============4760796217180163439=="
MIME-Version: 1.0
Subject: Re: Review Request 26963: SQOOP-1588: TO-side of Kite Connector -
 Write data to HDFS
From: "Veena Basavaraj" <vbasavaraj@cloudera.com>
To: "Veena Basavaraj" <vbasavaraj@cloudera.com>,
 "Qian Xu" <sx.away@googlemail.com>, "Sqoop" <sqoop-dev@incubator.apache.org>
Date: Fri, 31 Oct 2014 22:44:25 -0000
Message-ID: <20141031224425.7138.24090@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Veena Basavaraj" <noreply@reviews.apache.org>
References: <20141031224136.7138.16753@reviews.apache.org>
In-Reply-To: <20141031224136.7138.16753@reviews.apache.org>
Reply-To: "Veena Basavaraj" <vbasavaraj@cloudera.com>

--===============4760796217180163439==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Oct. 31, 2014, 3:41 p.m., Veena Basavaraj wrote:
> > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToDestroyer.java, line 49
> > <https://reviews.apache.org/r/26963/diff/4/?file=745369#file745369line49>
> >
> >     please add a comment to this and link to the tciker open for not doing merge in destroy. I would even want us to have 2 methods on destroy. I am going to ping Jarcec on this ticket. Here is the ticket for your review.
> >     https://issues.apache.org/jira/browse/SQOOP-1602
> >     
> >     This will be miss the cracks if we dont have a todo to revisit. I will update it whent he ticket is resolved.

it is https://issues.apache.org/jira/browse/SQOOP-1603

BTW, did you fix https://issues.apache.org/jira/browse/SQOOP-1602? 

what happend to the bug you raised about not splitting the load across 2 loaders in the TO phase?


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26963/#review59430
-----------------------------------------------------------


On Oct. 30, 2014, 9:48 p.m., Qian Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26963/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 9:48 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1588
>     https://issues.apache.org/jira/browse/SQOOP-1588
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Create a basic Kite connector that can write data (i.e. from a jdbc connection) to HDFS.
> 
> The scope is defined as follows:
> * Destination: HDFS
> * File Format: Avro Parquet and CSV.
> * Compression Codec: Use default
> * Partitioner Strategy: Not supported
> * Column Mapping: Not supported
> 
> 
> Diffs
> -----
> 
>   connector/connector-kite/pom.xml PRE-CREATION 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnector.java PRE-CREATION 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnectorConstants.java PRE-CREATION 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnectorError.java PRE-CREATION 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetExecutor.java PRE-CREATION 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteLoader.java PRE-CREATION 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToDestroyer.java PRE-CREATION 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToInitializer.java PRE-CREATION 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/LinkConfig.java PRE-CREATION 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/LinkConfiguration.java PRE-CREATION 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/ToFormat.java PRE-CREATION 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/ToJobConfig.java PRE-CREATION 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/ToJobConfiguration.java PRE-CREATION 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/util/InputValidation.java PRE-CREATION 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/util/KiteDataTypeUtil.java PRE-CREATION 
>   connector/connector-kite/src/main/resources/connector-configs.properties PRE-CREATION 
>   connector/connector-kite/src/main/resources/sqoopconnector.properties PRE-CREATION 
>   connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteExecutor.java PRE-CREATION 
>   connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteLoader.java PRE-CREATION 
>   connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteToDestroyer.java PRE-CREATION 
>   connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteToInitializer.java PRE-CREATION 
>   connector/connector-kite/src/test/resources/log4j.properties PRE-CREATION 
>   connector/pom.xml e98a0fc 
>   pom.xml f25a29f 
>   server/pom.xml 67baaa5 
>   test/pom.xml 7a80710 
> 
> Diff: https://reviews.apache.org/r/26963/diff/
> 
> 
> Testing
> -------
> 
> New unittests included. All passed.
> 
> 
> Thanks,
> 
> Qian Xu
> 
>


--===============4760796217180163439==--