Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 391FC17C14 for ; Fri, 31 Oct 2014 22:41:33 +0000 (UTC) Received: (qmail 16612 invoked by uid 500); 31 Oct 2014 22:41:32 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 16576 invoked by uid 500); 31 Oct 2014 22:41:32 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 16564 invoked by uid 500); 31 Oct 2014 22:41:32 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 16559 invoked by uid 99); 31 Oct 2014 22:41:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 Oct 2014 22:41:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B2C531DFA35; Fri, 31 Oct 2014 22:41:36 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8373732347601434152==" MIME-Version: 1.0 Subject: Re: Review Request 26963: SQOOP-1588: TO-side of Kite Connector - Write data to HDFS From: "Veena Basavaraj" To: "Veena Basavaraj" , "Qian Xu" , "Sqoop" Date: Fri, 31 Oct 2014 22:41:36 -0000 Message-ID: <20141031224136.7138.16753@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Veena Basavaraj" X-ReviewGroup: Sqoop X-ReviewRequest-URL: https://reviews.apache.org/r/26963/ X-Sender: "Veena Basavaraj" References: <20141031044853.7138.2971@reviews.apache.org> In-Reply-To: <20141031044853.7138.2971@reviews.apache.org> Reply-To: "Veena Basavaraj" X-ReviewRequest-Repository: sqoop-sqoop2 --===============8373732347601434152== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26963/#review59430 ----------------------------------------------------------- Ship it! Please fix the remaining ones. Some might be considered nitpicks, but we have to get there to this kind of standards so we dont have someone else joining the team wondering what everything means and what it does. If you disagree, please shoot me an email / ping me we shall work something out together:) connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnector.java can you add some java docs on this? or is it available somewhere else. I think we need to get more cautious about docs and tests with everyone. I dont mind even linking something off from here if you have suggestions let me know. connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnector.java thanks for following this guideline of linking a ticket number. connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetExecutor.java is there a ticket for this? or are you waiting for some ont to confirm. create a ticket and add the details there . connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToDestroyer.java please add a comment to this and link to the tciker open for not doing merge in destroy. I would even want us to have 2 methods on destroy. I am going to ping Jarcec on this ticket. Here is the ticket for your review. https://issues.apache.org/jira/browse/SQOOP-1602 This will be miss the cracks if we dont have a todo to revisit. I will update it whent he ticket is resolved. connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/ToFormat.java are you thinking of moving this to SDK so we can share it with other conenctors. DRY! connector/connector-kite/src/main/resources/connector-configs.properties its called link ( I fixed it in generid jdbc thi week) connector/connector-kite/src/main/resources/connector-configs.properties nice examples man! I love that you give the attention to details. connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteExecutor.java cool tests. pom.xml nice! I love this library for unit tests I have - Veena Basavaraj On Oct. 30, 2014, 9:48 p.m., Qian Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26963/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2014, 9:48 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1588 > https://issues.apache.org/jira/browse/SQOOP-1588 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Create a basic Kite connector that can write data (i.e. from a jdbc connection) to HDFS. > > The scope is defined as follows: > * Destination: HDFS > * File Format: Avro Parquet and CSV. > * Compression Codec: Use default > * Partitioner Strategy: Not supported > * Column Mapping: Not supported > > > Diffs > ----- > > connector/connector-kite/pom.xml PRE-CREATION > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnector.java PRE-CREATION > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnectorConstants.java PRE-CREATION > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnectorError.java PRE-CREATION > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetExecutor.java PRE-CREATION > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteLoader.java PRE-CREATION > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToDestroyer.java PRE-CREATION > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToInitializer.java PRE-CREATION > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/LinkConfig.java PRE-CREATION > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/LinkConfiguration.java PRE-CREATION > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/ToFormat.java PRE-CREATION > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/ToJobConfig.java PRE-CREATION > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/ToJobConfiguration.java PRE-CREATION > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/util/InputValidation.java PRE-CREATION > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/util/KiteDataTypeUtil.java PRE-CREATION > connector/connector-kite/src/main/resources/connector-configs.properties PRE-CREATION > connector/connector-kite/src/main/resources/sqoopconnector.properties PRE-CREATION > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteExecutor.java PRE-CREATION > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteLoader.java PRE-CREATION > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteToDestroyer.java PRE-CREATION > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteToInitializer.java PRE-CREATION > connector/connector-kite/src/test/resources/log4j.properties PRE-CREATION > connector/pom.xml e98a0fc > pom.xml f25a29f > server/pom.xml 67baaa5 > test/pom.xml 7a80710 > > Diff: https://reviews.apache.org/r/26963/diff/ > > > Testing > ------- > > New unittests included. All passed. > > > Thanks, > > Qian Xu > > --===============8373732347601434152==--