Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A6EC7178EE for ; Tue, 28 Oct 2014 21:05:52 +0000 (UTC) Received: (qmail 64747 invoked by uid 500); 28 Oct 2014 21:05:52 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 64707 invoked by uid 500); 28 Oct 2014 21:05:52 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 64692 invoked by uid 500); 28 Oct 2014 21:05:51 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 64687 invoked by uid 99); 28 Oct 2014 21:05:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Oct 2014 21:05:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5A7931DF83D; Tue, 28 Oct 2014 21:05:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0285837168230731435==" MIME-Version: 1.0 Subject: Re: Review Request 27248: SQOOP-1629:Add unique constraint on the Config table for name and type From: "Veena Basavaraj" To: "Abraham Elmahrek" , "Veena Basavaraj" , "Sqoop" Date: Tue, 28 Oct 2014 21:05:56 -0000 Message-ID: <20141028210556.7138.9347@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Veena Basavaraj" X-ReviewGroup: Sqoop X-ReviewRequest-URL: https://reviews.apache.org/r/27248/ X-Sender: "Veena Basavaraj" References: <20141028210336.7138.46082@reviews.apache.org> In-Reply-To: <20141028210336.7138.46082@reviews.apache.org> Reply-To: "Veena Basavaraj" X-ReviewRequest-Repository: sqoop-sqoop2 --===============0285837168230731435== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27248/ ----------------------------------------------------------- (Updated Oct. 28, 2014, 2:05 p.m.) Review request for Sqoop. Repository: sqoop-sqoop2 Description ------- see jira Note: This unique ness is stricter scross the entire sqoop system, since we want to be able to use the config names independently ( wihtout any configurable Id along with it ) to create jobs Note I have rebased to the latest on 28th morning/ Diffs (updated) ----- repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 514b5ac repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java f579b93 repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java 0bdb4c6 repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 3398c91 repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java ca40545 repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java 7f35f8c repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java 7687be7 Diff: https://reviews.apache.org/r/27248/diff/ Testing ------- yes Thanks, Veena Basavaraj --===============0285837168230731435==--