sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Veena Basavaraj" <vbasava...@cloudera.com>
Subject Re: Review Request 27248: SQOOP-1629:Add unique constraint on the Config table for name and type
Date Tue, 28 Oct 2014 22:15:36 GMT


> On Oct. 28, 2014, 3:01 p.m., Abraham Elmahrek wrote:
> > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java,
lines 782-785
> > <https://reviews.apache.org/r/27248/diff/6-8/?file=735205#file735205line782>
> >
> >     spacing seems off here.

i have used the IDE formatting


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27248/#review58891
-----------------------------------------------------------


On Oct. 28, 2014, 2:05 p.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27248/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 2:05 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see jira
> 
> Note: This unique ness is stricter scross the entire sqoop system, since we want to be
able to use the config names independently ( wihtout any configurable Id along with it ) to
create jobs
> 
> Note I have rebased to the latest on 28th morning/
> 
> 
> Diffs
> -----
> 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
514b5ac 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
f579b93 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java
0bdb4c6 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
3398c91 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java
ca40545 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java
7f35f8c 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java
7687be7 
> 
> Diff: https://reviews.apache.org/r/27248/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message