sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Veena Basavaraj" <vbasava...@cloudera.com>
Subject Re: Review Request 26592: SQOOP-1566: Fix the upgrade logic for SQOOP-1498
Date Tue, 14 Oct 2014 12:33:13 GMT


> On Oct. 13, 2014, 12:40 p.m., Jarek Cecho wrote:
> > core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java, line 137
> > <https://reviews.apache.org/r/26592/diff/1/?file=718486#file718486line137>
> >
> >     Similarly here: We are expecting a connector and not general configurable here
so the rename doesn't seem applicable, correct?

public final class MConnector extends MConfigurable, hope this clarifies it.


> On Oct. 13, 2014, 12:40 p.m., Jarek Cecho wrote:
> > core/src/main/java/org/apache/sqoop/driver/Driver.java, line 98
> > <https://reviews.apache.org/r/26592/diff/1/?file=718488#file718488line98>
> >
> >     Another example of the same :)

same as above.


> On Oct. 13, 2014, 12:40 p.m., Jarek Cecho wrote:
> > core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java, line 46
> > <https://reviews.apache.org/r/26592/diff/1/?file=718486#file718486line46>
> >
> >     This rename is not fully applicable here, right? We are indeed expecting mConnector
and not any configurable? E.g. Driver (another configurable) would be incorrect here, right?

public final class MConnector extends MConfigurable {


- Veena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26592/#review56402
-----------------------------------------------------------


On Oct. 13, 2014, 9:30 a.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26592/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2014, 9:30 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> - Mainly fix the upgrade logic for 1498 changes
> - rename the repository upgrader to Configurable upgrader - agreed by Jarcec. 
> 
> - rename configuration utils to MRConfigurationUtils, so it is not be confused with the
sqoop configuration/ configs
> - rename mapreduce to MR ( if this is not acceptable, happy to change it back)
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/job/etl/ExtractorContext.java 3272b56 
>   common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 9e762dc 
>   common/src/main/java/org/apache/sqoop/model/MConfigurable.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MConfigurableType.java PRE-CREATION 
>   common/src/main/java/org/apache/sqoop/model/MConnector.java 2f42191 
>   common/src/main/java/org/apache/sqoop/model/MDriver.java 685439e 
>   common/src/main/java/org/apache/sqoop/utils/ClassUtils.java 0be4d41 
>   common/src/main/java/org/apache/sqoop/validation/ConfigValidator.java eac789e 
>   common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java d5377f8 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java
87ac2af 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java
a069b3e 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java
b17aa21 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java
606b9fa 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnectorUpgrader.java
PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorError.java d544fb1 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java 54bdd13 
>   core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 5226926 
>   core/src/main/java/org/apache/sqoop/driver/Driver.java f1b45bb 
>   core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 847b73d 
>   core/src/main/java/org/apache/sqoop/driver/DriverUpgrader.java PRE-CREATION 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java df2a5ab 
>   core/src/main/java/org/apache/sqoop/driver/JobRequest.java 2666320 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 3ade247 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 97de893 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 95c7a4d 
>   core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java c2f8505 
>   core/src/main/resources/driver-config.properties.rej PRE-CREATION 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java dc4e8c8 
>   core/src/test/java/org/apache/sqoop/driver/TestDriverUpgrader.java PRE-CREATION 
>   core/src/test/java/org/apache/sqoop/driver/TestJobManager.java 3b475c6 
>   core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java e6e4760 
>   execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java
47f8478 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/ExecutionError.java PRE-CREATION

>   execution/mapreduce/src/main/java/org/apache/sqoop/job/MapreduceExecutionError.java
1dc12d1 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 5423b7b 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopInputFormat.java 1c1133a

>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 03d84d4

>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopNullOutputFormat.java
594b5e9 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java
1ebd3e4 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopReducer.java a55534a

>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopSplit.java dca4c90 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java
74e41df 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
10a7b1a 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
cf6e657 
>   repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
56ea147 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
9316687 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java
fc95222 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverHandling.java
d597bd8 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java
260c2a9 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java
0eb9df4 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java
01a05b2 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java
bbfe5bb 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestRespositorySchemaUpgrade.java
PRE-CREATION 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java
8402d8c 
>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 7109ae5

>   server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java aa773a9

>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 462579c 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 80e65b8 
>   shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java cbd34f5 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java a1bc5d5 
>   spi/src/main/java/org/apache/sqoop/connector/spi/ConfigurableUpgrader.java PRE-CREATION

>   spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java 879e428 
>   spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java 5315e1f 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java f89c546 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 76ebd3b 
> 
> Diff: https://reviews.apache.org/r/26592/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message