Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2D6EF97C5 for ; Mon, 26 Nov 2012 16:46:44 +0000 (UTC) Received: (qmail 30985 invoked by uid 500); 26 Nov 2012 16:46:43 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 30956 invoked by uid 500); 26 Nov 2012 16:46:43 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 30924 invoked by uid 500); 26 Nov 2012 16:46:42 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 30909 invoked by uid 99); 26 Nov 2012 16:46:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Nov 2012 16:46:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C4AB11C4C9D; Mon, 26 Nov 2012 16:46:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4560221531492836666==" MIME-Version: 1.0 Subject: Re: Review Request: SQOOP-673 Mapreduce submission manager should not call update() on finished submissions From: "Bilung Lee" To: "Bilung Lee" , "Sqoop" , "Jarek Cecho" Date: Mon, 26 Nov 2012 16:46:38 -0000 Message-ID: <20121126164638.26366.8316@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bilung Lee" X-ReviewGroup: Sqoop X-ReviewRequest-URL: https://reviews.apache.org/r/8154/ X-Sender: "Bilung Lee" References: <20121121052233.3393.7807@reviews.apache.org> In-Reply-To: <20121121052233.3393.7807@reviews.apache.org> Reply-To: "Bilung Lee" --===============4560221531492836666== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8154/#review13732 ----------------------------------------------------------- Ship it! Ship It! - Bilung Lee On Nov. 21, 2012, 5:22 a.m., Jarek Cecho wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8154/ > ----------------------------------------------------------- > = > (Updated Nov. 21, 2012, 5:22 a.m.) > = > = > Review request for Sqoop. > = > = > Description > ------- > = > Very simple patch that is simply putting update() call in status() method= into condition and is being executed only in case that loading submission = status is considered running. > = > = > This addresses bug SQOOP-673. > https://issues.apache.org/jira/browse/SQOOP-673 > = > = > Diffs > ----- > = > core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java c9c= 9cf4 = > = > Diff: https://reviews.apache.org/r/8154/diff/ > = > = > Testing > ------- > = > I've tested it on real cluster. > = > = > Thanks, > = > Jarek Cecho > = > --===============4560221531492836666==--