Mailing-List: contact sqoop-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: sqoop-dev@incubator.apache.org
Date: Mon, 27 Feb 2012 23:35:52 +0000 (UTC)
From: "jiraposter@reviews.apache.org (Commented) (JIRA)" <jira@apache.org>
To: sqoop-dev@incubator.apache.org
Message-ID: 
 <1308087108.25431.1330385752144.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1214822014.32051.1326322840806.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (SQOOP-425) Sqoop invokes ResultSet.isLast()
 which causes Sybase JDBC driver to hang
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/SQOOP-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217692#comment-13217692 ] 

jiraposter@reviews.apache.org commented on SQOOP-425:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4075/#review5370
-----------------------------------------------------------

Ship it!


Thanks for the patch!

- Bilung


On 2012-02-27 23:28:35, Cheolsoo Park wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4075/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-02-27 23:28:35)
bq.  
bq.  
bq.  Review request for Sqoop and Bilung Lee.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  The call to ResultSet.isLast() should be replaced by ResultSet.isAfterLast() where necessary in order to help support Sybase for data import.
bq.  
bq.  
bq.  This addresses bug SQOOP-425.
bq.      https://issues.apache.org/jira/browse/SQOOP-425
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    ./src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java 1294374 
bq.  
bq.  Diff: https://reviews.apache.org/r/4075/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Ran ant test
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Cheolsoo
bq.  
bq.


> Sqoop invokes ResultSet.isLast() which causes Sybase JDBC driver to hang
> ------------------------------------------------------------------------
>
>                 Key: SQOOP-425
>                 URL: https://issues.apache.org/jira/browse/SQOOP-425
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.3.0
>            Reporter: Arvind Prabhakar
>            Assignee: Cheolsoo Park
>
> The call to ResultSet.isLast() should be replaced by ResultSet.isAfterLast() where necessary in order to help support Sybase for data import.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira