shardingsphere-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sheng Wu <wu.sheng.841...@gmail.com>
Subject Re: [DISCUSS] Remove ShardingSphere SkyWalking agent plugins for legacy version from SkyWalking's master branch
Date Wed, 30 Jun 2021 23:50:18 GMT
Hi

```
   3.

https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.0.x-plugin
   4.

https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.1.0-plugin
   5.

https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-RC3-plugin
   6.

https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-plugin
```

What is the difference between 4.x and 4.0/4.1 plugins? Could some of them
be removed?
And RC3 should be removed as you have plugins for GA releases already.

Sheng Wu 吴晟
Twitter, wusheng1108


吴伟杰 <wuweijie@apache.org> 于2021年6月30日周三 下午11:19写道:

> Hi All,
>
> SkyWalking's master branch hosts 7 agent plugins for different versions of
> ShardingSphere.
> They think the plugins are too many. (
> https://github.com/apache/skywalking/pull/7171#issuecomment-868353013)
> Here is the list:
>
>    1.
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-jdbc-1.5.x-plugin
>    2.
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-3.x-plugin
>    3.
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.0.x-plugin
>    4.
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.1.0-plugin
>    5.
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-RC3-plugin
>    6.
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-plugin
>    7.
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/shardingsphere-5.0.0-beta-plugin
>
>
> Since the sharding-jdbc-1.5.x and the sharding-sphere-3.x have no longer
> been maintained, I propose to
> remove sharding-jdbc-1.5.x-plugin
> <
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-jdbc-1.5.x-plugin
> >
>  and sharding-sphere-3.x-plugin
> <
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-3.x-plugin
> >
> from
> SkyWalking's master branch to reduce maintenance costs.
>
> ------------------
>
> Sincerely,
> Weijie Wu (TeslaCN)
> Apache ShardingSphere
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message