servicecomb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wjm wjm <zzz...@gmail.com>
Subject Re: [DISCUSS] Require the review before merging the PR
Date Wed, 03 Apr 2019 14:23:42 GMT
+1

zhang_lei@boco.com.cn <zhang_lei@boco.com.cn> 于2019年4月3日周三 下午3:25写道:

> +1
>
> > 在 2019年4月3日,下午2:55,Zheng Feng <zh.feng@gmail.com> 写道:
> >
> > Hi,
> >
> > I just wonder if we can enable this setting [1] on servicecomb-pack [2]
> and
> > it could be helpful when reviewing the PR. I think at least one people
> > review the changes and approve before merging it. We have to raise a JIRA
> > for the infra team to do this setting. So I post this message here to see
> > if the others have any thought.
> >
> > Regards,
> > Zheng Feng
> >
> > [1]
> >
> https://help.github.com/en/articles/enabling-required-reviews-for-pull-requests
> > [2] https://github.com/apache/servicecomb-pack
>
>
> Zhang Lei.
>
>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message