From dev-return-5397-archive-asf-public=cust-asf.ponee.io@servicecomb.apache.org Thu Oct 18 14:27:19 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5C61418064E for ; Thu, 18 Oct 2018 14:27:19 +0200 (CEST) Received: (qmail 70155 invoked by uid 500); 18 Oct 2018 12:27:18 -0000 Mailing-List: contact dev-help@servicecomb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@servicecomb.apache.org Delivered-To: mailing list dev@servicecomb.apache.org Received: (qmail 70143 invoked by uid 99); 18 Oct 2018 12:27:17 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Oct 2018 12:27:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 696D918000F for ; Thu, 18 Oct 2018 12:27:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.888 X-Spam-Level: * X-Spam-Status: No, score=1.888 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id MJUHJX7bLsNU for ; Thu, 18 Oct 2018 12:27:16 +0000 (UTC) Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id D29CF5F125 for ; Thu, 18 Oct 2018 12:27:15 +0000 (UTC) Received: by mail-io1-f42.google.com with SMTP id l25-v6so20825212ioj.0 for ; Thu, 18 Oct 2018 05:27:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=glFMmymCEgR9Jwp92DeXNiABAGbMdKctKcg7l1BCTl8=; b=X282918oMSsHPdRmOYLFS5WieVvsdV67NnaA37qi3PpOwCwxhRewt3Un7D6S32PeCd +abgP6OsBhdrBpjzm8DBtMN0+FJ12MgptH+mpFS1GgdgY6x7KZB9AksoAVPR+mULUy2D HMJnEJD5jNJJUX8+bpJQQ8m/qHMTUgE+XAXMd4EOyYl/NSv4rCSLGMzZ5jomV50aswqW Qoms2YMFMWzp5t9edNYqjZUxAdPN6pB28MRJN/FbKF3e070YtPbnVKDj9APBLUHI4TqV o+Vx4kuH7Tljv2VRu/D3zY5Cw/H1sfKydNP863bAqmJ8TVBjq7jTT7xb4oM82HDVckeh wACw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=glFMmymCEgR9Jwp92DeXNiABAGbMdKctKcg7l1BCTl8=; b=WLCWNBqBrPVcuC4EPngEB3W9oIptz72iwRBpwIUlK6S6esdWu6B5NRhYfrpeRHtT1i a08Gq+BkobpijdmON2A/pqiBgr9zHkGIEKtYTY1P0u98reiuvQcDpMnaG4uqH3OuGLNp vyG7mtLn3Rnsa+pkwmzFXYJnnURTzLE2WheFgAo1tqaUcb3UILy3NkuD2A8jeD5Nvg1A ExhTG3FtnPQrCpwGnUYSXS2rI39N+GBQ4Et+c8LYy9Sosazt13yQ7xunrsv6WfbAjVhf 0A/zmVqWhCPOHA9XrtlucbVt799JlNieONktecj5QVFT3MeT7vxues5tv0Bq8kDx1Dev kDSw== X-Gm-Message-State: AGRZ1gKE4r0YG7wtcEn/TRVnhzwVGGwtSo8DIuFhos0hHwddBmdkEyYK L2NexDCG3P2K71qBj21ib8JupPw7vw27FucB2k+sxQ== X-Google-Smtp-Source: AJdET5c+RzB8OeOwqsoRgtDRGORqvFQ/UrVHGy5Gv7NCrPBcLNv2kO8SJWAcjIuFfgpbq/2BP6RhNdcvm2EHYNzYFBQ= X-Received: by 2002:a6b:5a0f:: with SMTP id o15-v6mr50875iob.136.1539865629460; Thu, 18 Oct 2018 05:27:09 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Zheng Feng Date: Thu, 18 Oct 2018 20:26:58 +0800 Message-ID: Subject: Re: [DISCUSS]The forwardPolicy of Saga should be able to configurethe maximum of retries To: dev@servicecomb.apache.org Content-Type: multipart/alternative; boundary="000000000000d8908305787fe7ff" --000000000000d8908305787fe7ff Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Is it a global configration for all the transactions or it can be applied for the specified one ? =E6=96=B0=E9=81=93=E5=9C=BA=E5=BC=80=E5=BC=A0=E4=BA=86 = =E4=BA=8E2018=E5=B9=B410=E6=9C=8816=E6=97=A5=E5=91=A8=E4=BA=8C =E4=B8=8B=E5= =8D=885:17=E5=86=99=E9=81=93=EF=BC=9A > I create a new issue in JIRA. > issue address: > https://issues.apache.org/jira/browse/SCB-962 > > > > > ------------------ =E5=8E=9F=E5=A7=8B=E9=82=AE=E4=BB=B6 -----------------= - > =E5=8F=91=E4=BB=B6=E4=BA=BA: "Willem Jiang"; > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2018=E5=B9=B410=E6=9C=8816=E6=97=A5= (=E6=98=9F=E6=9C=9F=E4=BA=8C) =E4=B8=8B=E5=8D=884:29 > =E6=94=B6=E4=BB=B6=E4=BA=BA: "dev"; > > =E4=B8=BB=E9=A2=98: Re: [DISCUSS]The forwardPolicy of Saga should be able= to configurethe > maximum of retries > > > > Yeah, it makes sense to add the maximum number of forward retry. > Could you fill a JIRA for it? > It could be great if you can send a PR of this issue :) > > Willem Jiang > > Twitter: willemjiang > Weibo: =E5=A7=9C=E5=AE=81willem > > On Tue, Oct 16, 2018 at 4:22 PM =E6=96=B0=E9=81=93=E5=9C=BA=E5=BC=80=E5= =BC=A0=E4=BA=86 wrote: > > > > Hi, all: > > > > > > Currently, service comb saga would keep trying transaction part when > using forwardPolicy. > > The policy is sufficient for some situations, such as network > fluctuations or service unavailability temporarily. > > But for other situations like wrong address, wrong params or wrong SQL, > it is possible to cause saga retry infinitely. > > So, I recommend that Saga should be able to configure the maximum of > retries for forwardPolicy. > > When users configure the maximum of retries and transaction failed > repeatedly, Saga should throw exception or do backward. > > > > > > Best Wishes & Regards --000000000000d8908305787fe7ff--