servicecomb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yhs0092 <yhs0...@163.com>
Subject Re: [Discuss][JavaChassis] about customization of vertx org.apache.servicecomb.transport.rest.vertx.RestBodyHandler
Date Wed, 31 Oct 2018 09:54:51 GMT
Hi, one of the JavaChassis exception wrapped in RestBodyHandler is added by me.
I will try to remove the JavaChassis exceptions in RestBodyHandler and see whether it can
works well.


Yours sincerely


Yao Haishi
yhs0092@163.com


On 10/31/2018 09:00,wjm wjm<zzzwjm@gmail.com> wrote:
currently we
customized org.apache.servicecomb.transport.rest.vertx.RestBodyHandler
1.disable upload feature when uploadDir is null, this is a general
requirement
2.wrap some exceptions to JavaChassis exception, this is not a general
requirement

if there is only customization 1, maybe we can try to raise a PR to vertx
otherwise we always forget to merge latest vertx logic to our code.

maybe we can confirm if customization 2 is necessary.
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message