servicecomb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sure" <sure_0...@qq.com>
Subject 回复: [Discuss] Should we clean up vendor/github.com/go-ecosystem for ServiceCenter
Date Fri, 08 Jun 2018 02:58:46 GMT
we do not change the code in go-ecosystem package and we can remove these files from project


Just make sure the same version of this package compiled with etcd components when make the
release. 





------------------ 原始邮件 ------------------
发件人: "willem.jiang"<willem.jiang@gmail.com>;
发送时间: 2018年6月7日(星期四) 中午11:32
收件人: "dev"<dev@servicecomb.apache.org>;

主题: Re: [Discuss] Should we clean up vendor/github.com/go-ecosystem for ServiceCenter



If we changed the code, we should move it third party directory.
@Asif @Cuiyihua  Could you double check with YangBo?


Willem Jiang

Twitter: willemjiang
Weibo: 姜宁willem

On Thu, Jun 7, 2018 at 10:29 AM, Yang Bo <oakyang@gmail.com> wrote:

> Hi All,
>
> Currently we store github.com/go-ecosystem/grpc-gateway and
> go-grpc-prometheus under the vendor directory.
>
> The vendor directory should only contain manifest file and all other code
> should be fetched from third party repository.
>
> If we have made some modification to those libraries, then we need to move
> them to a proper place.
>
> --
> Best Regards,
> Yang.
>
Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message