From dev-return-3730-archive-asf-public=cust-asf.ponee.io@servicecomb.apache.org Tue Apr 17 11:50:09 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 193CA180649 for ; Tue, 17 Apr 2018 11:50:08 +0200 (CEST) Received: (qmail 74141 invoked by uid 500); 17 Apr 2018 09:50:08 -0000 Mailing-List: contact dev-help@servicecomb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@servicecomb.apache.org Delivered-To: mailing list dev@servicecomb.apache.org Received: (qmail 74130 invoked by uid 99); 17 Apr 2018 09:50:08 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Apr 2018 09:50:08 +0000 From: GitBox To: dev@servicecomb.apache.org Subject: [GitHub] yangbor commented on a change in pull request #328: [SCB-479] Add proxy to service-center in frontend Message-ID: <152395860768.29277.17171991593833311884.gitbox@gitbox.apache.org> Date: Tue, 17 Apr 2018 09:50:07 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit yangbor commented on a change in pull request #328: [SCB-479] Add proxy to service-center in frontend URL: https://github.com/apache/incubator-servicecomb-service-center/pull/328#discussion_r182015996 ########## File path: frontend/Readme.md ########## @@ -41,15 +40,6 @@ go run main.go This will bring up the Service-Center UI on [http://127.0.0.1:30103](http://127.0.0.1:30103). If you want to change the listening ip/port, you can modify it in the configuration file (service-center/frontend/conf/app.conf : FRONTEND_HOST_IP, FRONTEND_HOST_PORT). -##### NOTE Review comment: The proxy is built into the frontend. And it's meant to be used by the JS api to access the Service Center apis. There are no need to configure/setup the proxy. It just starts up along with the frontend web service. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services