servicecomb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] yangbor commented on a change in pull request #639: [SCB-422] prometheus switch to new mechanism
Date Mon, 09 Apr 2018 06:25:37 GMT
yangbor commented on a change in pull request #639: [SCB-422] prometheus switch to new mechanism
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/639#discussion_r179996570
 
 

 ##########
 File path: metrics/metrics-integration/metrics-prometheus/pom.xml
 ##########
 @@ -43,7 +42,10 @@
       <groupId>org.apache.servicecomb</groupId>
       <artifactId>metrics-core</artifactId>
     </dependency>
-
+    <dependency>
 
 Review comment:
   Shouldn't the scope set to 'test' here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message