servicecomb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] liubao68 commented on a change in pull request #632: [SCB-456]Provider a way to input configuration from a Map
Date Mon, 09 Apr 2018 03:59:11 GMT
liubao68 commented on a change in pull request #632: [SCB-456]Provider a way to input configuration
from a Map
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/632#discussion_r179982646
 
 

 ##########
 File path: foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java
 ##########
 @@ -52,9 +52,15 @@
 
   private static final String MICROSERVICE_CONFIG_LOADER_KEY = "cse-microservice-config-loader";
 
+  private static ConfigModel model = new ConfigModel();
+
   private ConfigUtil() {
   }
 
+  public static void setConfigs(Map<String, Object> config) {
 
 Review comment:
   I think if we can provide a more convenient method to add configs . e.g. 
   public static void addConfig(String k, Object v)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message