From dev-return-3293-archive-asf-public=cust-asf.ponee.io@servicecomb.apache.org Sat Mar 31 11:34:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9BB3118064A for ; Sat, 31 Mar 2018 11:34:03 +0200 (CEST) Received: (qmail 94574 invoked by uid 500); 31 Mar 2018 09:34:02 -0000 Mailing-List: contact dev-help@servicecomb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@servicecomb.apache.org Delivered-To: mailing list dev@servicecomb.apache.org Received: (qmail 94561 invoked by uid 99); 31 Mar 2018 09:34:02 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 31 Mar 2018 09:34:02 +0000 From: GitBox To: dev@servicecomb.apache.org Subject: [GitHub] mt-monster commented on a change in pull request #630: [SCB-444]try to optimize autoDiscovery function Message-ID: <152248884159.10642.10242341337219451171.gitbox@gitbox.apache.org> Date: Sat, 31 Mar 2018 09:34:01 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit mt-monster commented on a change in pull request #630: [SCB-444]try to optimize autoDiscovery function URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/630#discussion_r178427894 ########## File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/IpPortManager.java ########## @@ -50,6 +50,12 @@ private boolean autoDiscoveryInited = false; + private int maxRetryTimes; + + public int getMaxRetryTimes() { + return maxRetryTimes; Review comment: no need ,already retry twice ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services