servicecomb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] WillemJiang commented on a change in pull request #628: [SCB-385] Metrics publisher switch to new mechanism
Date Sat, 31 Mar 2018 23:15:43 GMT
WillemJiang commented on a change in pull request #628: [SCB-385] Metrics publisher switch
to new mechanism
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/628#discussion_r178444270
 
 

 ##########
 File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/registry/AbstractServiceRegistry.java
 ##########
 @@ -195,16 +195,11 @@ private boolean needSetFrameworkVersion() {
     if (serviceCenterInfo == null) {
       LOGGER.warn("Server startup when service center not started and cannot retrieve version
info, assume latest.");
       return true;
-    } else {
-      Version scVersion = VersionUtils.getOrCreate(serviceCenterInfo.getVersion());
-      Version frameworkVersion = VersionUtils.getOrCreate(Const.SERVICECENTER_FRAMEWORK_VERSION);
-
-      if (scVersion.compareTo(frameworkVersion) >= 0) {
-        return true;
-      } else {
-        return false;
-      }
     }
+
 
 Review comment:
   This change doesn't relate to this JIRA, we need to avoid mixing the unrelated changes
together. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message