servicecomb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] liubao68 commented on a change in pull request #630: [SCB-444]try to optimize autoDiscovery function
Date Sat, 31 Mar 2018 08:45:45 GMT
liubao68 commented on a change in pull request #630: [SCB-444]try to optimize autoDiscovery
function
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/630#discussion_r178426930
 
 

 ##########
 File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/IpPortManager.java
 ##########
 @@ -50,6 +50,12 @@
 
   private boolean autoDiscoveryInited = false;
 
+  private int maxRetryTimes;
+
+  public int getMaxRetryTimes() {
+    return maxRetryTimes;
 
 Review comment:
   Maybe maxRetryTimes should be bigger than 2. Return Max(maxRestryTime, 2)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message