servicecomb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] wujimin commented on a change in pull request #565: [SCB-355]If auth failed,sc/cc will not connect server to reduce server pressure
Date Sun, 04 Mar 2018 12:17:14 GMT
wujimin commented on a change in pull request #565: [SCB-355]If auth failed,sc/cc will not
connect server to reduce server pressure
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/565#discussion_r172046771
 
 

 ##########
 File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/task/MicroserviceInstanceRegisterTask.java
 ##########
 @@ -56,6 +56,11 @@ public void onMicroserviceRegisterTask(MicroserviceRegisterTask task)
{
 
   @Override
   protected boolean doRegister() {
+    if (microserviceInstance.getServiceId() == null) {
 
 Review comment:
   why register microservice failed, but try to register microservice instance?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message