servicecomb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] wujimin commented on a change in pull request #562: [SCB-358] fix bug for monitor output id that register only name without any tags
Date Thu, 01 Mar 2018 00:41:19 GMT
wujimin commented on a change in pull request #562: [SCB-358] fix bug for monitor output id
that register only name without any tags
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/562#discussion_r171433099
 
 

 ##########
 File path: foundations/foundation-metrics/src/main/java/org/apache/servicecomb/foundation/metrics/publish/Metric.java
 ##########
 @@ -35,14 +36,33 @@ public String getName() {
   }
 
   public Metric(String id, double value) {
-    String[] nameAndTag = id.split("\\(");
-    this.tags = new HashMap<>();
-    String[] tagAnValues = nameAndTag[1].split("[=,)]");
-    for (int i = 0; i < tagAnValues.length; i += 2) {
-      this.tags.put(tagAnValues[i], tagAnValues[i + 1]);
+    if (validateMetricId(id)) {
+      this.tags = new HashMap<>();
+      this.value = value;
+      String[] nameAndTag = id.split("[()]");
 
 Review comment:
   why need to split tags?
   servo/spectator's already have tags information.
   
   if lost these informations caused by our mechanism, then we should change our mechanism.
   this is why i DO NOT agree work on current mechanism.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message