servicecomb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data module (Re-organized)
Date Thu, 01 Jan 1970 00:00:00 GMT
WillemJiang commented on a change in pull request #555: [SCB-327] Update metrics publish data
module (Re-organized)
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/555#discussion_r168059325
 
 

 ##########
 File path: foundations/foundation-metrics/src/main/java/org/apache/servicecomb/foundation/metrics/publish/DefaultHealthCheckExtraData.java
 ##########
 @@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-package org.apache.servicecomb.metrics.common;
+package org.apache.servicecomb.foundation.metrics.publish;
 
 public class DefaultHealthCheckExtraData {
 
 Review comment:
   What's the relationship between the DefaultHealthCheckExtraData and HealthCheckResult.extraData?
   We don't need to use the String to store result,  it's easy to use toString method to turn
the instance of HealthCheckExtraData into a string.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message