sentry-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SENTRY-1047) Use existing validators in SentryShellSolr
Date Wed, 03 Feb 2016 03:55:39 GMT

    [ https://issues.apache.org/jira/browse/SENTRY-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129741#comment-15129741
] 

Hadoop QA commented on SENTRY-1047:
-----------------------------------

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12785908/SENTRY-1047.patch against master.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} all tests passed

Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/1145/console

This message is automatically generated.

> Use existing validators in SentryShellSolr
> ------------------------------------------
>
>                 Key: SENTRY-1047
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1047
>             Project: Sentry
>          Issue Type: Task
>          Components: Service, Solr Plugin
>    Affects Versions: 1.7.0
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>             Fix For: 1.7.0
>
>         Attachments: SENTRY-1047.patch
>
>
> Right now, following the pattern of the Hive shell, the Solr shell manually implements
validators, i.e.:
> https://github.com/apache/incubator-sentry/blob/597a3cdd319be84f2417c96d24db01553f264551/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SolrTSentryPrivilegeConvertor.java#L115-L130
> It would be better if we automatically used the existing validators, so they don't need
to be implemented in multiple places.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message