ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alok Lal" <a...@hortonworks.com>
Subject Review Request 37140: RANGER-594 Policy Validation: Change the logic to generate friendly error messages to be like used for Service and Service def
Date Wed, 05 Aug 2015 20:38:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37140/
-----------------------------------------------------------

Review request for ranger and Madhan Neethiraj.


Bugs: RANGER-594
    https://issues.apache.org/jira/browse/RANGER-594


Repository: ranger


Description
-------

Policy Validation: Change the logic to generate friendly error messages to be like used for
Service and Service def
- Changes of interest are in policy vaidation
- Other changes are to remove the code that was put in place in service and serivce-def files
as we were trying different approaches on how to do the validation error handing.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java c40efc9

  agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java
8817049 
  agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefValidator.java
75372c2 
  agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceValidator.java
3cfaa3e 
  agents-common/src/main/java/org/apache/ranger/plugin/model/validation/ValidationFailureDetails.java
64e7e50 
  agents-common/src/main/java/org/apache/ranger/plugin/model/validation/ValidationFailureDetailsBuilder.java
ab67f1f 
  agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestValidationFailureDetails.java
815d41c 

Diff: https://reviews.apache.org/r/37140/diff/


Testing
-------

existing tests work.


Thanks,

Alok Lal


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message