From commits-return-36670-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Mon Sep 2 13:11:39 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 41094180674 for ; Mon, 2 Sep 2019 15:11:39 +0200 (CEST) Received: (qmail 98939 invoked by uid 500); 2 Sep 2019 14:12:24 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 98930 invoked by uid 99); 2 Sep 2019 14:12:24 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Sep 2019 14:12:24 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] [pulsar] codelipenghui edited a comment on issue #4806: A Pulsar producer should be able to produce messages of different schemas Message-ID: <156742989866.9939.11525351095565672430.gitbox@gitbox.apache.org> Date: Mon, 02 Sep 2019 13:11:38 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit codelipenghui edited a comment on issue #4806: A Pulsar producer should be able to produce messages of different schemas URL: https://github.com/apache/pulsar/issues/4806#issuecomment-527143151 @yittg Great work! Left few comments: 1. I think use `CommandGetOrCreateSchema` and `CommandGetOrCreateSchemaResponse` is more suitable. 2. Similar to the reader cache, the writer cache can be handled in the same way. 3. Need to consider the batch message, messages of different schema versions cannot be contained in a batch. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services