From commits-return-10793-archive-asf-public=cust-asf.ponee.io@pulsar.incubator.apache.org Tue Jul 10 20:59:01 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 217C7180676 for ; Tue, 10 Jul 2018 20:58:59 +0200 (CEST) Received: (qmail 64114 invoked by uid 500); 10 Jul 2018 18:58:58 -0000 Mailing-List: contact commits-help@pulsar.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.incubator.apache.org Delivered-To: mailing list commits@pulsar.incubator.apache.org Received: (qmail 64099 invoked by uid 99); 10 Jul 2018 18:58:58 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Jul 2018 18:58:58 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] sijie commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers Message-ID: <153124913755.9453.13653615917586864229.gitbox@gitbox.apache.org> Date: Tue, 10 Jul 2018 18:58:57 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit sijie commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r201449924 ########## File path: tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/topologies/PulsarCluster.java ########## @@ -112,6 +108,12 @@ private PulsarCluster(PulsarClusterSpec spec) { .withEnv("zookeeperServers", ZKContainer.NAME) .withEnv("configurationStoreServers", CSContainer.NAME + ":" + CS_PORT) .withEnv("clusterName", clusterName); + + this.s3Container = new S3Container(clusterName, S3Container.NAME) Review comment: a cluster is built from a spec. an alternative is to add a flag `enableTieredStorage()` in the cluster spec. the cluster can start s3 container if tiered storage is enabled. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services