pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers
Date Tue, 10 Jul 2018 18:58:57 GMT
sijie commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers
URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r201455619
 
 

 ##########
 File path: tests/integration/compaction/src/test/java/org/apache/pulsar/tests/integration/TestCompaction.java
 ##########
 @@ -171,23 +154,16 @@ private static void waitAndVerifyCompacted(PulsarClient client, String
topic,
         }
     }
 
-    @Test
-    public void testPublishWithAutoCompaction() throws Exception {
-        PulsarClusterUtils.runOnAnyBroker(docker, clusterName,
-                                          PulsarClusterUtils.PULSAR_ADMIN, "tenants",
-                                          "create", "compaction-test-auto",
-                                          "--allowed-clusters", clusterName,
-                                          "--admin-roles", "admin");
-        PulsarClusterUtils.runOnAnyBroker(docker, clusterName,
-                PulsarClusterUtils.PULSAR_ADMIN, "namespaces",
-                "create", "--clusters", "test", "compaction-test-auto/ns1");
-        PulsarClusterUtils.runOnAnyBroker(docker, clusterName,
-                PulsarClusterUtils.PULSAR_ADMIN, "namespaces",
+    @Test(dataProvider = "ServiceUrls")
+    public void testPublishWithAutoCompaction(String serviceUrl) throws Exception {
+
+        this.createTenantName("compaction-test-auto", clusterName, "admin");
 
 Review comment:
   same as above

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message