pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on a change in pull request #2078: Enhance Pulsar cluster with container logs
Date Tue, 03 Jul 2018 19:57:30 GMT
sijie commented on a change in pull request #2078: Enhance Pulsar cluster with container logs
URL: https://github.com/apache/incubator-pulsar/pull/2078#discussion_r199932477
 
 

 ##########
 File path: tests/integration/semantics/src/test/java/org/apache/pulsar/tests/integration/functions/PulsarFunctionsTestBase.java
 ##########
 @@ -50,8 +50,8 @@ protected static String getExclamationClass(Runtime runtime) {
     }
 
     @BeforeClass
-    public static void setupCluster() throws Exception {
-        PulsarClusterTestBase.setupCluster();
+    public void setupCluster() throws Exception {
 
 Review comment:
   why do you need to remove 'static' here? All tests here share same cluster, and they all
annotated with `BeforeClass`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message