From commits-return-8439-archive-asf-public=cust-asf.ponee.io@pulsar.incubator.apache.org Tue May 22 23:53:25 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B365C180638 for ; Tue, 22 May 2018 23:53:24 +0200 (CEST) Received: (qmail 11163 invoked by uid 500); 22 May 2018 21:53:23 -0000 Mailing-List: contact commits-help@pulsar.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.incubator.apache.org Delivered-To: mailing list commits@pulsar.incubator.apache.org Received: (qmail 11154 invoked by uid 99); 22 May 2018 21:53:23 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 May 2018 21:53:23 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] merlimat commented on a change in pull request #1821: Closing client when Proxyconnection is disconnected Message-ID: <152702600328.10710.4763628044194732735.gitbox@gitbox.apache.org> Date: Tue, 22 May 2018 21:53:23 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit merlimat commented on a change in pull request #1821: Closing client when Proxyconnection is disconnected URL: https://github.com/apache/incubator-pulsar/pull/1821#discussion_r190065269 ########## File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java ########## @@ -140,6 +140,10 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception { directProxyHandler.outboundChannel.close(); } + if (client != null) { + client.close(); + } Review comment: Uhm, that doesn't sound a good option to me ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services