From commits-return-7560-archive-asf-public=cust-asf.ponee.io@pulsar.incubator.apache.org Wed May 2 09:20:40 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id BE417180675 for ; Wed, 2 May 2018 09:20:39 +0200 (CEST) Received: (qmail 22562 invoked by uid 500); 2 May 2018 07:20:38 -0000 Mailing-List: contact commits-help@pulsar.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.incubator.apache.org Delivered-To: mailing list commits@pulsar.incubator.apache.org Received: (qmail 22505 invoked by uid 99); 2 May 2018 07:20:38 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 May 2018 07:20:38 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] sijie commented on a change in pull request #1708: Refactor functions to use Sink interface Message-ID: <152524563802.6454.9397934595081285265.gitbox@gitbox.apache.org> Date: Wed, 02 May 2018 07:20:38 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit sijie commented on a change in pull request #1708: Refactor functions to use Sink interface URL: https://github.com/apache/incubator-pulsar/pull/1708#discussion_r185410631 ########## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/sink/RuntimeSink.java ########## @@ -29,7 +32,9 @@ *

There is a default implementation provided for wrapping up the user provided {@link Sink}. Pulsar sink * should be implemented using this interface to ensure supporting effective-once. */ -public interface RuntimeSink extends Sink { +//public interface RuntimeSink extends Sink { Review comment: the changes here are not needed? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services